[Bug 776927] gl: gldownload: convert GstGLMemory to GstDmaBuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776927

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354656|none                        |needs-work
             status|                            |

--- Comment #53 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 354656:
 --> (https://bugzilla.gnome.org/review?bug=776927&attachment=354656)

This is not a complete review, I'll have a look more in dept later, I also need
to test it again. I've added one comment that was not address, it's a
regression when running with GLX platform (GST_GL_PLATFORM=GLX).

::: ext/gl/gstgldownloadelement.c
@@ +372,3 @@
     features = gst_caps_get_features (src_caps, 0);

+#if GST_GL_HAVE_PLATFORM_EGL && GST_GL_HAVE_DMABUF

You are missing an extra run-time check that platform is EGL. On mesa, the
export does not fail on GLX, but EGLImage won't work later on causing issues.
It's also otherwise pointless to try on anything else then EGL.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.