[Bug 784321] New: vaapi: MVC encoding via sinkcaps without setting num-views property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784321

            Bug ID: 784321
           Summary: vaapi: MVC encoding via sinkcaps without setting
                    num-views property
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gstreamer-vaapi
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: zzoon at igalia.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
                CC: bsreerenj at gmail.com, vjaquez at igalia.com
     GNOME version: ---

Currenlty, this is producing correct MVC encoded data (with setting num-views)
gst-launch-1.0 -v videotestsrc pattern=ball name=left videotestsrc name=right
glstereomix name=mix \
left. ! video/x-raw,width=640,height=480! glupload ! mix. \
right. ! video/x-raw,width=640,height=480! glupload ! mix. \
mix. ! video/x-raw'(memory:GLMemory)',multiview-mode=frame-by-frame ! queue !
glcolorconvert ! gldownload ! vaapih264enc num-views=2 ! filesink
location=mvc_test.264

But this is not doing the same (without setting num-views) even though there is
logic to hanlde this [1], and produces wrong stream:

gst-launch-1.0 -v videotestsrc pattern=ball name=left videotestsrc name=right
glstereomix name=mix \
left. ! video/x-raw,width=640,height=480! glupload ! mix. \
right. ! video/x-raw,width=640,height=480! glupload ! mix. \
mix. ! video/x-raw'(memory:GLMemory)',multiview-mode=frame-by-frame ! queue !
glcolorconvert ! gldownload ! vaapih264enc ! filesink location=mvc_test.264

This is because view_ids array is not set at the moment when num-views is being
changed.
Currently view_ids array is set properly only if num-views are set, which means
this is not handling the case num-views is changed on running.

[1]
https://cgit.freedesktop.org/gstreamer/gstreamer-vaapi/tree/gst-libs/gst/vaapi/gstvaapiencoder_h264.c#n2833

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.