[Bug 784250] rtpstats: Glib CRITICAL _gst_util_uint64_scale_int: assertion 'denom > 0' failed

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784250

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354573|none                        |needs-work
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 354573:
 --> (https://bugzilla.gnome.org/review?bug=784250&attachment=354573)

::: gst/rtpmanager/rtpstats.c
@@ +39,3 @@
   guint32 new_packet_rate;

+  if ((gint) ctx->clock_rate <= 0) {

I think Miguel just got it wrong when he wrote this stats. Just change
rtpstats.h to store clock_rate as a gint, this is a superset of
gstrtpjitterbuffer (gint32) and rtpsource (gint). I've check other places, like
in rtpbin, they use uint but that's taken from the caps, so that's correct.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.