[Bug 776936] v4l2videodec: bufferpool size is fixed to 2

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776936

--- Comment #3 from Michael Tretter <m.tretter at pengutronix.de> ---
(In reply to Nicolas Dufresne (stormer) from comment #2)
> Review of attachment 343003 [details] [review]:
> 
> In the particular case, the buffers will be copied, there is no need to
> respect the negotiated number of buffers. I agree it should respect the
> minimum suggested by the driver though. On the other end, it's driver role
> to enforce this minimum through when REQBUFS is called. Maybe I'm missing
> something, it would be nice to clarify.

The minimum was OK, but I was more concerned about the maximum, but I missed
that the buffers are copied. I now understand that the V4l2Allocator maintains
an internal queue and that this prevents the allocation of additional buffers
in the buffer pool. Is this correct?

Maybe a comment that explains the 2 or using GST_V4L2_MIN_BUFFERS instead of
the 2 would be helpful.

Anyway, thanks for the clarification. This patch is not needed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.