[Bug 779422] qtmux: Update modification times when sending the moov

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Mar 2 17:55:01 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=779422

--- Comment #3 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 346975:
 --> (https://bugzilla.gnome.org/review?bug=779422&attachment=346975)

::: gst/isomp4/gstqtmux.c
@@ +1937,3 @@
+        atoms_get_current_qt_time ();
+    qtpad->trak->tkhd.modification_time = atoms_get_current_qt_time ();
+  }

How about getting the time just once and writing the same all over. I guess
there is a small chance that the times will be slightly different.

Not sure it matters in the end but it seems to make more sense to have them all
with a common value.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list