[Bug 760837] dash, mpdparser: Implement the flow to check invalid adaption sets or representations according to ISO/IEC 23009-1 : section 8.3
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Mar 2 18:06:55 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=760837
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #319348|none |needs-work
status| |
--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 319348:
--> (https://bugzilla.gnome.org/review?bug=760837&attachment=319348)
Please provide a test for this also
::: ext/dash/gstmpdparser.c
@@ +1853,3 @@
gchar *actuate;
+ gboolean has_subsegmentAlignment = FALSE;
+ gboolean has_subsegmentStartsWithSAP = FALSE;
And run gst-indent over your code to fix indentation
@@ +1972,3 @@
}
+ if (0 == g_list_length (new_adap_set->Representations)) {
This is O(n), better would be to just check if ->Representations == NULL
@@ +2121,3 @@
}
+ if (0 == g_list_length (new_period->AdaptationSets)) {
And here
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list