[Bug 778237] dash, mpdparser: problem with German DVB-T2 DASH preview streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778237

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #345027|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 345027:
 --> (https://bugzilla.gnome.org/review?bug=778237&attachment=345027)

::: ext/dash/gstmpdparser.c
@@ +1645,3 @@
+   *   no sub-SegmentTemplates: check timeline and duration
+   *   all Representations have SegmentTemplates: don't check
+   */

Please explain in a bit more detail what you're doing here and why, and why it
is valid to omit the check

@@ +1646,3 @@
+   *   all Representations have SegmentTemplates: don't check
+   */
+  do_sanity_check = 0x02; // no sub SegmentTemplates: do sanity check

Instead of using magic bitflags, please use descriptive booleans (and don't use
// comments)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.