[Bug 779011] hlsdemux: Try to find type at the end of a fragment

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Mar 3 09:37:37 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=779011

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
> And why doesn't this find the type while buffers are arriving,
> but finds it on finish then? Isn't it looking at exactly the
> same data?

As I understand it, it doesn't find the type while buffers are arriving because
it doesn't even attempt to do any typefinding yet there. When the data is very
small (<2 kB), this

    /* Typefind could miss if buffer is too small. In this case we
     * will retry later */
    if (buffer_size >= (2 * 1024) || at_eos) {
      caps =
          gst_type_find_helper_for_data (GST_OBJECT_CAST (hlsdemux), info.data,
          info.size, &prob);
    }

will never run.

I think the patch makes sense.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list