[Bug 779515] vorbisdec: Reset decoder in more situations

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Mar 3 10:29:33 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=779515

--- Comment #3 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 347121:
 --> (https://bugzilla.gnome.org/review?bug=779515&attachment=347121)

::: ext/vorbis/gstvorbisdec.c
@@ +587,3 @@
+     * initialized yet. */
+    if ((vd->initialized || (vd->vi.rate != 0)) &&
+        (gst_ogg_packet_data (packet))[0] == 0x01) {

That would require a more granular system *IF* it's an actual scenario that can
happen.

If you reset everything when you get a huffmann table, it will then refuse to
decode (it doesn't have the generic information contained in the initialization
header).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list