[Bug 778496] vtenc: should support GLMemory

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778496

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Nick Kallen from comment #9)

> The code does a lot of this:
> 
>   GST_VIDEO_ENCODER_STREAM_UNLOCK (self);
>       VTCompressionSessionCompleteFrames (self->session,
>       kCMTimePositiveInfinity);
>   GST_VIDEO_ENCODER_STREAM_LOCK (self);

Taking the encoder's stream lock is required from the other threads to do
anything with the GstVideoEncoder. If you don't do anything else with it and
you can guarantee that the GstVideoCodecFrame* you pass around directly is a)
always ending up in your callback (so that you can unref it) and b) you always
get it once and only the ones you provided (e.g. not some random other pointer
sometimes), then you can also pass the frame directly. It's just more
requirements on the VT API which you have to check to ensure everything is
memory-safe.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.