[Bug 779344] plugin: Unify static and dynamic plugin interface

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779344

Nirbheek Chauhan <nirbheek.chauhan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347213|none                        |needs-work
             status|                            |

--- Comment #17 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
Review of attachment 347213:
 --> (https://bugzilla.gnome.org/review?bug=779344&attachment=347213)

::: docs/plugins/inspect/plugin-oss4.xml
@@ +7,3 @@
   <license>LGPL</license>
   <source>gst-plugins-good</source>
+  <package>GStreamer Good Plug-ins git</package>

Looks like this is "source release" everywhere else?

::: docs/plugins/inspect/plugin-pulseaudio.xml
@@ +7,3 @@
   <license>LGPL</license>
   <source>gst-plugins-good</source>
+  <package>GStreamer Good Plug-ins git</package>

Ditto

::: docs/plugins/inspect/plugin-shout2send.xml
@@ +7,3 @@
   <license>LGPL</license>
   <source>gst-plugins-good</source>
   <package>libshout2</package>

<package> here seems to be wrong; please change it to "GStreamer Good Plug-ins
source release" since you're touching this file anyway ;)

@@ +21,3 @@
           <direction>sink</direction>
           <presence>always</presence>
+          <details>application/ogg; audio/ogg; video/ogg; audio/mpeg,
mpegversion=(int)1, layer=(int)[ 1, 3 ]</details>

This change is incorrect; the plugin does support webm when libshout >= 2.3.0;
grep for "SHOUT_FORMAT_WEBM".

Ideally this should be changed at build-time, but I don't see how...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.