[Bug 779453] gst-player: fix gst-player failed to load external subtitle uri

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779453

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347027|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 347027:
 --> (https://bugzilla.gnome.org/review?bug=779453&attachment=347027)

::: gst-libs/gst/player/gstplayer.c
@@ +585,2 @@
   /* if have suburi from previous playback then free it */
+  gchar *suburi = NULL;

Don't put new variable declarations into the middle of a block

@@ +586,3 @@
+  gchar *suburi = NULL;
+  g_object_get(self->playbin, "suburi", &suburi, NULL);
+  if (self->suburi && suburi && strcmp(self->suburi, suburi)==0) {

Shouldn't self->suburi always be the same as playbin's suburi? When is it not?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.