[Bug 779453] gst-player: fix gst-player failed to load external subtitle uri

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779453

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347364|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 347364:
 --> (https://bugzilla.gnome.org/review?bug=779453&attachment=347364)

Please explain in more detail what this fixes in the commit message. Also we
don't use "Signed-off-by: ..."

::: gst-libs/gst/player/gstplayer.c
@@ +586,3 @@
   /* if have suburi from previous playback then free it */
+  g_object_get(self->playbin, "suburi", &suburi, NULL);
+  if (self->suburi && suburi && strcmp(self->suburi, suburi)==0) {

So we reset the suburi here if there was a previous one and it was the same as
the current one? Why? Shouldn't we just always reset it to NULL, no matter if
playbin or GstPlayer thought there was a previous one or not?


Please also run "gst-indent" over your changes before sending patches.

@@ +590,3 @@
     self->suburi = NULL;
     g_object_set (self->playbin, "suburi", NULL, NULL);
+    g_free (suburi);

You're leaking suburi here if suburi!=NULL but any of the other conditions is
false.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.