[Bug 779138] webrtcdsp: expose voice activity detection.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779138

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346580|none                        |accepted-commit_now
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 346580:
 --> (https://bugzilla.gnome.org/review?bug=779138&attachment=346580)

Looks good to me. Just have a small question below, nothing important really.
One note, if the VAD buffer size it's not a multiple of 10ms, our message
timestamp will be slightly off. Maybe we should document ? Otherwise it's good
for merging.

::: ext/webrtcdsp/gstwebrtcdsp.cpp
@@ +624,3 @@
+  if (self->voice_detection) {
+    GEnumClass *likelihood_class = (GEnumClass *)
+        g_type_class_ref (GST_TYPE_WEBRTC_VOICE_DETECTION_LIKELIHOOD);

Considering this type is used for a property, I'm wondering if using
g_type_class_peek() could be sufficient (mostly a curiosity).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.