[Bug 779146] dmabuf: be able to negotiate tiled surfaces

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779146

--- Comment #13 from Julien Isorce <julien.isorce at gmail.com> ---
Review of attachment 347168:
 --> (https://bugzilla.gnome.org/review?bug=779146&attachment=347168)

Overall looks good thx! Just a few minor remarks. Also the name should be
reviewed by Nicolas too since I am confused with comment #8, see my question in
the review.

::: gst-libs/gst/allocators/gstdmabufdrmmodifiermeta.c
@@ +88,3 @@
+
+static void
+gst_dmabuf_drm_modifier_meta_free (GstMeta * sync_meta, GstBuffer * buffer)

What is the "sync_" ?

@@ +89,3 @@
+static void
+gst_dmabuf_drm_modifier_meta_free (GstMeta * sync_meta, GstBuffer * buffer)
+{

Should it set the modifier to 0 /* DRM_FORMAT_MOD_NONE */ for cosmetic reasons
?

@@ +147,3 @@
+        g_strdup_printf
+        ("GstDmabufDrmModifierMeta, dmabuf.drm_modifier=(guint64){ %" PRIu64
+        " };", modifier);

G_GUINT64_FORMAT instead of PRIu64 ?

::: gst-libs/gst/allocators/gstdmabufdrmmodifiermeta.h
@@ +41,3 @@
+  GstMeta parent;
+
+  guint64 modifier;

I think comment #8 says GstDmabufMeta with field drm_modifier but I may have
missed something.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.