[Bug 768079] waylandsink: add support wayland presentation time interface

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768079

--- Comment #3 from George Kiagiadakis <gkiagia at tolabaki.gr> ---
I am looking a bit into this.

First of all, I have rebased again on top of current master (conflicted with
dmabuf stuff - fixed):
https://git.collabora.com/cgit/user/gkiagia/gst-plugins-bad.git/log/?h=wayland-presentation

Some comments:

* I don't particularly like doing the streaming thread throttling in prepare()
(with that g_cond_wait()). It doesn't make it clear where the throttling
happens, I was confused for quite some time. It will probably also make it hard
to implement unlock() and waiting for preroll.

* Numbers look confusing. It looks like the render time of the next buffer is
always smaller than the last presentation time by a factor of about 3 seconds
in my tests:

base_time 285:57:44.954398746 prepared_buffer_pts 0:00:00.149999999
presentation_time 285:57:45.033256712 refresh_duration 0:00:00.016666666
render_time 285:57:41.282301844

It looks to me as if all buffers are actually very late, but synchronization
happens nevertheless because of the g_cond_wait in prepare(). Maybe I am
missing something, I'll continue looking...

* There is a g_cond_signal() in show_frame() which doesn't make any sense, as
show_frame() runs on the same thread as prepare().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.