[Bug 779855] shmsrc: add uri handler

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779855

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347640|none                        |needs-work
             status|                            |

--- Comment #1 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 347640:
 --> (https://bugzilla.gnome.org/review?bug=779855&attachment=347640)

::: sys/shm/gstshmsrc.c
@@ +485,3 @@
+gst_shm_src_uri_get_uri (GstURIHandler * handler)
+{
+  return NULL;

I'm pretty sure we can do better than returning NULL here.

@@ +506,3 @@
+  }
+
+  if (gst_uri_query_has_key (gst_uri, "socket-path")) {

Any reason to put the socket path as a key instead of shm:///path/to/socket ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.