[Bug 746762] alsa: add uri handler

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746762

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347629|none                        |needs-work
             status|                            |

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 347629:
 --> (https://bugzilla.gnome.org/review?bug=746762&attachment=347629)

::: ext/alsa/gstalsasink.c
@@ +81,3 @@
+    gst_alsasink_init_interfaces (g_define_type_id);
+    G_IMPLEMENT_INTERFACE (GST_TYPE_URI_HANDLER,
+        gst_alsasink_uri_handler_init));

None sense, this is a sink.

::: ext/alsa/gstalsasrc.c
@@ +201,3 @@
+          gst_uri_unref (src->uri);
+
+        src->uri = gst_uri_from_string (g_value_get_string (value));

May fail.

@@ +203,3 @@
+        src->uri = gst_uri_from_string (g_value_get_string (value));
+
+        gst_object_set_properties_from_uri_query_parameters (G_OBJECT (src),
src->uri);

Need filtering, at least device.

@@ +236,3 @@
+        gchar *string = gst_uri_to_string (src->uri);
+
+        g_value_set_string (value, string);

g_value_take_string() please.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.