[Bug 778237] dash, mpdparser: problem with German DVB-T2 DASH preview streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778237

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347123|none                        |reviewed
             status|                            |

--- Comment #4 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 347123:
 --> (https://bugzilla.gnome.org/review?bug=778237&attachment=347123)

::: ext/dash/gstmpdparser.c
@@ +1668,3 @@
+        }
+        if (have_segmenttemplate)
+          do_sanity_check &= ~SANITY_CHECK_REASON_NO_SUBTEMPLATES;

Shouldn't this be done only if *all* Representations had a segment template? We
could have one that had a segment template and others without (using the
default values from the parent).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.