[Bug 779957] souphttpsrc: Manipulate range header when seek to 0

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779957

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347778|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 347778:
 --> (https://bugzilla.gnome.org/review?bug=779957&attachment=347778)

Please remove the "common" change from the patch

::: ext/soup/gstsouphttpsrc.c
@@ +1474,2 @@
   /* Update the position if we are retrying */
+  if (src->msg && src->request_position != src->read_position) {

This would mean that we also add the Range header from 0 in other cases when it
wasn't there in the beginning.

Maybe if request_position == 0, we should just *remove* the Range header?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.