[Bug 779957] souphttpsrc: Manipulate range header when seek to 0
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Mar 13 09:54:55 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=779957
--- Comment #5 from Paul Kim <paul.hyunil at lge.com> ---
(In reply to Sebastian Dröge (slomo) from comment #1)
> Review of attachment 347778 [details] [review]:
>
> Please remove the "common" change from the patch
>
> ::: ext/soup/gstsouphttpsrc.c
> @@ +1474,2 @@
> /* Update the position if we are retrying */
> + if (src->msg && src->request_position != src->read_position) {
>
> This would mean that we also add the Range header from 0 in other cases when
> it wasn't there in the beginning.
>
> Maybe if request_position == 0, we should just *remove* the Range header?
I uploaded a new patch "souphttpsrc: Remove range header when seek to 0" to
follow your feedback. Please let me know if you feel need to change some.
Thanks.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list