[Bug 779790] waylandsink: add offset setting for multiplane dmabuf

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Mar 13 10:52:41 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=779790

George Kiagiadakis <gkiagia at tolabaki.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gkiagia at tolabaki.gr

--- Comment #2 from George Kiagiadakis <gkiagia at tolabaki.gr> ---
Created attachment 347818
  --> https://bugzilla.gnome.org/attachment.cgi?id=347818&action=edit
waylandsink: fix memory offset calculation for multi-plane dmabuf buffers

The offset calculation was indeed wrong. In my older implementations I was
using 0 for the offset, which worked at least (while the current implementation
doesn't work for sure). The correct solution is indeed mem->offset + skip,
which works regardless of how many file descriptors & planes there are.

I think the attached patch is doing this correctly now. Nicolas?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list