[Bug 779790] waylandsink: add offset setting for multiplane dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779790

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347818|none                        |needs-work
             status|                            |

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 347818:
 --> (https://bugzilla.gnome.org/review?bug=779790&attachment=347818)

Yes, this is the right method I believe. This probably fixes YUV handling with
latest Weston. On PC, the best way to test is to use vivid capture driver,
loaded with mplane=2. And then:

  v4l2src io-mode=dmabuf ! video/x-raw,format... ! waylandsink

As mention, I would error-out if a plane is not found though.

::: ext/wayland/wllinuxdmabuf.c
@@ +113,3 @@
+      zwp_linux_buffer_params_v1_add (params, fd, i, m->offset + skip,
+          stride, 0, 0);
+    }

I think we should handle the else/error case here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.