[Bug 780064] gstglformat.c fails to compile with a warning.

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Mar 14 23:47:10 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=780064

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347956|none                        |needs-work
             status|                            |

--- Comment #1 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 347956:
 --> (https://bugzilla.gnome.org/review?bug=780064&attachment=347956)

Not quite correct.

::: gst-libs/gst/gl/gstglformat.c
@@ -152,3 @@
     case GST_VIDEO_FORMAT_BGR:
-      n_plane_components = 3;
-      break;

This needs to stay

@@ +153,3 @@
     case GST_VIDEO_FORMAT_RGB16:
     case GST_VIDEO_FORMAT_BGR16:
+      n_plane_components = 3;

This should be return GST_GL_RGB565

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list