[Bug 779146] dmabuf: be able to negotiate tiled surfaces

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779146

--- Comment #30 from Scott D Phillips <scott.d.phillips at intel.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #29)
> > > ::: gst-libs/gst/allocators/gstdmabufmeta.h
> > > @@ +41,3 @@
> > > +  GstMeta parent;
> > > +
> > > +  guint64 drm_modifier;
> > > 
> > > Modifiers are applied per plane in other API. This must be incorrect.
> > 
> > Which API? There is just a single modifier with ADDFB2. From drm_mode.h:
> 
> Modifiers are per-plane, as per the Kernel API. This also need to be
> reflected in the negotiations stuff (you'll notice the value 4, use
> GST_VIDEO_MAX_PLANES in gst though).
> 
> http://lxr.free-electrons.com/source/include/uapi/drm/drm_mode.h#L426

There is a single modifier for the ADDFB2 command, even though there are 4
modifier fields:

http://lxr.free-electrons.com/source/include/uapi/drm/drm_mode.h#L416

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.