[Bug 780108] New: dashdemux: invalid enum conversion in SIDX seek error handling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780108

            Bug ID: 780108
           Summary: dashdemux: invalid enum conversion in SIDX seek error
                    handling
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: scott.d.phillips at intel.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

This patch introduces some assignments of one enum type into a
variable of a different enum type:

> 141f3b2 dashdemux: If a SIDX seek failed although we're in the correct segment, disable the SIDX usage for this segment

Which causes this compile failure due to warnings:

../subprojects/gst-plugins-bad/ext/dash/gstdashdemux.c:1350:42: error: implicit
conversion from enumeration type 'GstIsoffParserResult' to different
enumeration type 'GstSidxParserStatus' (aka 'enum _GstSidxParserStatus')
[-Werror,-Wenum-conversion]                                                     
        dashstream->sidx_parser.status = GST_ISOFF_PARSER_UNEXPECTED;
                                       ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../subprojects/gst-plugins-bad/ext/dash/gstdashdemux.c:2290:47: error: implicit
conversion from enumeration type 'GstIsoffParserResult' to different
enumeration type 'GstSidxParserStatus' (aka 'enum _GstSidxParserStatus')
[-Werror,-Wenum-conversion]                                                     
            dash_stream->sidx_parser.status = GST_ISOFF_PARSER_UNEXPECTED;
                                            ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../subprojects/gst-plugins-bad/ext/dash/gstdashdemux.c:2774:49: error: implicit
conversion from enumeration type 'GstIsoffParserResult' to different
enumeration type 'GstSidxParserStatus' (aka 'enum _GstSidxParserStatus')
[-Werror,-Wenum-conversion]                                                     
              dash_stream->sidx_parser.status = GST_ISOFF_PARSER_UNEXPECTED;
                                              ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~

I'm not sure what the right value is instead of GST_ISOFF_PARSER_UNEXPECTED,
maybe GST_ISOFF_SIDX_PARSER_FINISHED?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.