[Bug 780111] New: _gst_param_array_validate is not correctly implemented

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780111

            Bug ID: 780111
           Summary: _gst_param_array_validate is not correctly implemented
    Classification: Platform
           Product: GStreamer
           Version: 1.11.2
                OS: Linux
            Status: NEW
          Severity: major
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: nicolas at ndufresne.ca
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

The param validation function are supposed to fix the data, and return TRUE if
the data is changed. The code in _gst_param_array_validate() is instead
assuming that FALSE means failure. This breaks bunch of things, including the
actual validation or safe mode usage. It also breaks if you try to set an empty
array. On that last point, I believe the param_spec should have allowed to
define the minimum / maximum size for this array. It will be hard to add later.
Finally, this should be unit tested really, it's an easy candidate.

I'll soon post a patch that at least fix the validation logic, I'd like
feedback for the min/max (if we decide we want that, then we'll mark this bug
as blocker). Any help is appreciated, using the new Array stuff in properties
has taken me much more time then expected.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.