[Bug 768248] vaapiencode: Add Encoding region-of-interest (ROI) support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768248

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346551|none                        |needs-work
             status|                            |

--- Comment #21 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 346551:
 --> (https://bugzilla.gnome.org/review?bug=768248&attachment=346551)

::: gst-libs/gst/vaapi/gstvaapiencoder.c
@@ +1211,3 @@
 }

+#if 0

Why is this code disabled? Should it be removed?

@@ +1243,3 @@
+#else
+gboolean
+gst_vaapi_encoder_add_roi (GstVaapiEncoder * encoder, GstVaapiROI * roi)

Document this function. Especially if @roi transfers its ownership.

@@ +1263,3 @@
+
+gboolean
+gst_vaapi_encoder_del_roi (GstVaapiEncoder * encoder, GstVaapiROI * roi)

ditto.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.