[Bug 780100] video: add support for BGR and BGRA formats with 12 bits per channel

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780100

--- Comment #9 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 348073:
 --> (https://bugzilla.gnome.org/review?bug=780100&attachment=348073)

::: gst-libs/gst/video/video-format.h
@@ +103,3 @@
+ * @GST_VIDEO_FORMAT_GBR_12LE: planar 4:4:4 RGB, 12 bits per channel
+ * @GST_VIDEO_FORMAT_GBRA_12BE: planar 4:4:4:4 ARGB, 12 bits per channel
+ * @GST_VIDEO_FORMAT_GBRA_12LE: planar 4:4:4:4 ARGB, 12 bits per channel

I didn't realize this was planar RGB. I'm thinking out loud here, but could we
create a notation to differentiate packed RGB from planar RGB. When I read the
format first, I though it was going to be packed, with 64bit pixels, and each
component being padded. Clearly this is not the case.

Other then that, I'm surprised of the component / plane order, but I need to
document myself.

::: gst-libs/gst/video/video-info.c
@@ +918,3 @@
+    case GST_VIDEO_FORMAT_GBRA_12LE:
+    case GST_VIDEO_FORMAT_GBRA_12BE:
+      info->stride[0] = GST_ROUND_UP_4 (width * 2);

Your pack/unpack function only require 16bit alignment. Do you really need to
round up here ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.