[Bug 779524] buffer with video meta information do not support memory split buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779524

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347147|none                        |needs-work
             status|                            |

--- Comment #13 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 347147:
 --> (https://bugzilla.gnome.org/review?bug=779524&attachment=347147)

::: gst-libs/gst/video/gstvideometa.c
@@ +298,3 @@
+ * Attaching metadata to @buffer require that the memories attached to
+ * the buffer are Plane-alignment. Failing to do so will possible cause
+ * memory errors.

I'd try another phrasing. Maybe "Each plane must fit within a single
#GstMemory. That means you may have a single memory for all planes, or one
memory per plane. The start of the memory does not need to align with the start
of the plane. Merging #GstMemory on map is currently not supported by this
API." Or something along these lines, I use the term #GstMemory as this is what
effectively wraps one chunk of data in GStreamer and can be cross-referenced.
Note that most of the time the GstMemory will align with the start of the
plane, that because you can hide padding using GstMemory::offset. That also
makes it easier to calculate the offset, as you just have to add the GstMemory
size to get the next offset.

::: gst-libs/gst/video/video-frame.c
@@ +66,3 @@
  *
+ * If video frame has GstVideoMeta the buffer requires to have Plane-aligned
+ * memories.

Same here, something like "A single GstMemory or a GstMemory for each plane"

@@ +235,3 @@
  *
+ * If video frame has GstVideoMeta the buffer requires to have Plane-aligned
+ * memories.

Same.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.