[Bug 779831] h264parse (baseparse?) fail to pass not-linked upstream sometimes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779831

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #348155|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 348155:
 --> (https://bugzilla.gnome.org/review?bug=779831&attachment=348155)

::: gst/videoparsers/gsth264parse.c
@@ +1032,3 @@
+      /* Dropping will return GST_FLOW_OK */
+      gst_base_parse_finish_frame (parse, frame, map.size);
+      ret = h264parse->last_ret;

Why do we even get here if non-OK was returned previously? After ERROR was
returned, it should have returned that to upstream already.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.