[Bug 779668] GST_DEBUG_BIN_TO_DOT: creates invalid .dot file when GstStructure parameter contains string with "@"

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779668

Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vincent.penquerch at collabora
                   |                            |.co.uk

--- Comment #5 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
I tracked the escaping down to:

gst/gst_private.h:#define GST_ASCII_IS_STRING(c) (g_ascii_isalnum((c)) || ((c)
== '_') || \
    ((c) == '-') || ((c) == '+') || ((c) == '/') || ((c) == ':') || \
    ((c) == '.'))


Adding @ fixes this, but this seems like the type of change to have random
repercussions elsewhere.

The string is escaped once in gst_string_wrap/gst_value_serialize_string, and
then escaped in debug_dump_get_object_params, which treats the previous
escaping backslashes as data.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.