[Bug 780140] souphttpsrc: Implement soup session sharing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780140

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #348081|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 348081:
 --> (https://bugzilla.gnome.org/review?bug=780140&attachment=348081)

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +441,3 @@
   demux->priv->input_adapter = gst_adapter_new ();
   demux->downloader = gst_uri_downloader_new ();
+  gst_uri_downloader_set_parent (demux->downloader, GST_ELEMENT_CAST (demux));

This creates a circular reference cycle between demux and downloader. The
downloader should probably just use a GWeakRef here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.