[Bug 779831] h264parse (baseparse?) fail to pass not-linked upstream sometimes

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Mar 17 11:44:04 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=779831

--- Comment #5 from Jan Schmidt <thaytan at noraisin.net> ---
(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 348155 [details] [review]:
> 
> ::: gst/videoparsers/gsth264parse.c
> @@ +1032,3 @@
> +      /* Dropping will return GST_FLOW_OK */
> +      gst_base_parse_finish_frame (parse, frame, map.size);
> +      ret = h264parse->last_ret;
> 
> Why do we even get here if non-OK was returned previously? After ERROR was
> returned, it should have returned that to upstream already.

The problem is baseparse keeps processing more of the input packet on
not-linked, and eventually returns whatever the last packet returns

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list