[Bug 775487] gstplayer: Move to playbin3 and GstStreams API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775487

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #348250|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 348250:
 --> (https://bugzilla.gnome.org/review?bug=775487&attachment=348250)

::: gst-libs/gst/player/gstplayer.c
@@ +1890,3 @@
+  gst_message_parse_streams_selected (msg, &collection);
+
+  if (collection) {

if (!collection)
  return;

Keep indentation small :) Also elsewhere the same

@@ +1908,3 @@
+      GstStreamType stream_type;
+      const gchar *stream_id;
+      stream = gst_message_streams_selected_get_stream (msg, i);

Transfer full according to docs, so need to unref the stream.

Also generally, you probably want to connect to the signals of all the streams
to know about tags/caps/etc changes

@@ +1912,3 @@
+      stream_id = gst_stream_get_stream_id (stream);
+      if (stream_type & GST_STREAM_TYPE_AUDIO)
+        self->audio_sid = g_strdup (stream_id);

If multiple audios are selected, you would assign them all here and leak memory

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.