[Bug 775487] gstplayer: Move to playbin3 and GstStreams API

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Mar 20 10:12:11 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=775487

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #348254|none                        |accepted-commit_now
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 348254:
 --> (https://bugzilla.gnome.org/review?bug=775487&attachment=348254)

::: gst-libs/gst/player/gstplayer.c
@@ +2082,3 @@
+        if (self->use_playbin3) {
+          if (g_str_equal (self->subtitle_sid, stream_info->stream_id))
+            info->language = g_path_get_basename (suburi);

Hm why do we set the language to the basename of the URI? It should be set to
whatever language tag is produced by that. Weird!

But you just keep behaviour here so that's fine.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list