[Bug 775487] gstplayer: Move to playbin3 and GstStreams API

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Mar 20 10:38:45 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=775487

--- Comment #18 from Seungha Yang <sh.yang at lge.com> ---
(In reply to Sebastian Dröge (slomo) from comment #11)
> Review of attachment 348249 [details] [review]:
> 
> I was more thinking of something in the GstPlayer config, i.e.
> gst_player_set/get_config(). Or is that too tricky because the pipeline is
> already created at initialization and deeply entangled with the thread?

Yes, it's not clear as current flow. As you know, GstPlayer object creates
playbin in its main thread at the beginning.

Firstly, I also tried to find a way to use config structure because I also
thought that gst_player_new_playbin3() seems not cool... 
But allowing playbin3 only by env variable also seems too unkind API in my
opinion.
What about an API like gst_player_new_with_config(.., GstStructure * config) ??

> ::: gst-libs/gst/player/gstplayer.c
> @@ +2770,3 @@
> +    GstPlayerSignalDispatcher * signal_dispatcher)
> +{
> +  static GOnce once = G_ONCE_INIT;
> 
> You have to share the GOnce with the other one, otherwise you'll call it
> twice :)
Oh, I missed it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list