[Bug 775487] gstplayer: Move to playbin3 and GstStreams API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775487

--- Comment #21 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Seungha Yang from comment #20)

> > @@ +1908,3 @@
> > +      GstStreamType stream_type;
> > +      const gchar *stream_id;
> > +      stream = gst_message_streams_selected_get_stream (msg, i);
> > 
> > Transfer full according to docs, so need to unref the stream.
> > 
> > Also generally, you probably want to connect to the signals of all the
> > streams to know about tags/caps/etc changes
> 
> If my understanding is correct, I attached stream-notify signal to
> collection not for each stream. So we can know the change of every stream
> now by attachment 348255 [details] [review]

Ack

> > @@ +1912,3 @@
> > +      stream_id = gst_stream_get_stream_id (stream);
> > +      if (stream_type & GST_STREAM_TYPE_AUDIO)
> > +        self->audio_sid = g_strdup (stream_id);
> > 
> > If multiple audios are selected, you would assign them all here and leak
> > memory
> 
> Humm... As far as I know (although I've never use inputselector with
> playbin3), multiple audios in streams-selected msg is only possible by using
> custom combiner like inputselector. In that case, I guess decodebin3 will
> add all audio tracks' stream-ids in selected-streams message. But, it's
> weird behaviour, because player never know activated one by using
> selected-streams message.

This might be done automatically be playbin3 in the future. Consider a stream
where you have two audio streams that should be played together for example,
which some containers can specify but we don't support currently.

It would be good to at least catch this case here and do something meaningful
instead of having an unhappy surprise later when playbin3 is extended :)

> About that, we should do 2 more works now in my opinion.
> - Support custom-combiner in GstPlayer (use of playbin/playbin3's
> "{video,audio,text}-stream-combiner" properties).
> - Filter non-activated stream out from selected-streams message (posted by
> decodebin3) at playbin3, in order for selected-streams to have only one
> stream-id per stream-type.

For later, just handle it in a meaningful way in GstPlayer for now without too
much complications.



For the configuration of using playbin3, please go with an environment variable
for now

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.