[Bug 759533] vaapisink: doesn't upload packed formats correctly

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=759533

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #347017|none                        |needs-work
             status|                            |

--- Comment #18 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 347017:
 --> (https://bugzilla.gnome.org/review?bug=759533&attachment=347017)

I like this idea. We need to refactor it with the wayland backend

::: gst-libs/gst/vaapi/gstvaapiwindow_x11.c
@@ +272,3 @@
+
+  priv->surface_format = GST_VIDEO_FORMAT_ENCODED;
+  priv->use_vpp = GST_VAAPI_DISPLAY_HAS_VPP (GST_VAAPI_OBJECT_DISPLAY
(window));

I would call this variable has_vpp

@@ +434,3 @@
+      goto error_unsupported_format;
+  }
+  if (!gst_vaapi_filter_set_cropping_rectangle (priv->filter, src_rect))

is this cropping really needed?

@@ +436,3 @@
+  if (!gst_vaapi_filter_set_cropping_rectangle (priv->filter, src_rect))
+    return NULL;
+  if (!gst_vaapi_filter_set_target_rectangle (priv->filter, dst_rect))

also is this rectangle?

@@ +525,3 @@
     return FALSE;

+  if (need_vpp && priv->use_vpp) {

what would happen if need_vpp but doesn't have use_vpp? the method will return
TRUE without signal any error condition

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.