[Bug 779145] dmabuf export from vaapi encoders fails

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779145

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346591|none                        |needs-work
             status|                            |

--- Comment #4 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 346591:
 --> (https://bugzilla.gnome.org/review?bug=779145&attachment=346591)

I have just tested the patch with this pipeline 

gst-launch-1.0 v4l2src io-mode=dmabuf-import ! vaapipostproc ! vaapisink

And surprisingly it works (it's an integrated camera in my laptop). Honestly, I
didn't expect it.

I said this, because sometime ago, Julien wrote another approach to this on
commit 1dbcc8a0e199f2da6a0ab8e949f13341916128a3 and I had to revert it (commit
7472826a3633d803d55def32dee58eb8d318e3ae) because it leaked file descriptors.
But with your patch there is no leakage.

Said this, in my opinion, the correct patch should be aligned the Julien
approach because we could avoid this gst_vaapi_buffer_proxy_release_data()
call.

--- Comment #5 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 346591:
 --> (https://bugzilla.gnome.org/review?bug=779145&attachment=346591)

I have just tested the patch with this pipeline 

gst-launch-1.0 v4l2src io-mode=dmabuf-import ! vaapipostproc ! vaapisink

And surprisingly it works (it's an integrated camera in my laptop). Honestly, I
didn't expect it.

I said this, because sometime ago, Julien wrote another approach to this on
commit 1dbcc8a0e199f2da6a0ab8e949f13341916128a3 and I had to revert it (commit
7472826a3633d803d55def32dee58eb8d318e3ae) because it leaked file descriptors.
But with your patch there is no leakage.

Said this, in my opinion, the correct patch should be aligned the Julien
approach because we could avoid this gst_vaapi_buffer_proxy_release_data()
call.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.