[Bug 780397] dashdemux: Fix SEEK of multi-period On-Demand profile

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780397

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #348483|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 348483:
 --> (https://bugzilla.gnome.org/review?bug=780397&attachment=348483)

::: ext/dash/gstdashdemux.c
@@ +1345,3 @@
+        gst_mpd_parser_get_period_start_time (dashdemux->client);
+    if (ts > period_start)
+      ts -= period_start;

What if ts <= period_start? Especially the == case seems useful to handle here.
The < case is probably an error and we should just error out?

Would it make sense to first add the presentation offset, and then do the
subtraction?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.