[Bug 753754] Add GstValueList and GstValueArray support to gst-python

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753754

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #348593|none                        |needs-work
             status|                            |

--- Comment #16 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 348593:
 --> (https://bugzilla.gnome.org/review?bug=753754&attachment=348593)

Looks about right, but adding some unit tests would be very welcome :)

::: gi/overrides/gstmodule.c
@@ -130,0 +130,40 @@
+static PyObject *
+gi_gst_int_range_from_value (const GValue * value)
+{
... 37 more ...

Please raise an exception here.

@@ -130,0 +130,83 @@
+static PyObject *
+gi_gst_int_range_from_value (const GValue * value)
+{
... 80 more ...

Sounds like you should raise an exception here.

@@ +271,3 @@
+  return 0;
+
+    goto fail;

Same.

@@ +348,3 @@
+  return 0;
+
+    PyErr_SetString (PyExc_KeyError,

Same.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.