[Bug 776446] rawvideoparse internal data stream error with bt2020 colorimetry if resolution is not 4k

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776446

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #348494|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 348494:
 --> (https://bugzilla.gnome.org/review?bug=776446&attachment=348494)

It might make sense to have some kind of "none" mode where it is just not added
to the caps and the default handling happens

::: gst/rawparse/gstrawvideoparse.c
@@ +330,3 @@
+  g_object_class_install_property (object_class,
+      PROP_COLORIMETRY,
+      g_param_spec_string ("colorimetry", "Colorimetry", "Colorimetry",

This is a product of enums, not a string: GstVideoColorRange,
GstVideoColorMatrix, GstVideoTransferFunction, GstVideoColorPrimaries

@@ +336,3 @@
+      PROP_CHROMA_SITE,
+      g_param_spec_string ("chroma-site", "Chroma site", "Chroma site",
+          DEFAULT_CHROMA_SITE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)

This is an enum: GstVideoChromaSite

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.