[Bug 780601] New: aalib-config prefix argument is not forwarded correctly

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780601

            Bug ID: 780601
           Summary: aalib-config prefix  argument is not forwarded
                    correctly
    Classification: Platform
           Product: GStreamer
           Version: 1.10.4
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: mattyclarkson at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

When '--with-aalib-prefix' is sets 'aalib_args' with '--prefix' as so:

    if test x$aalib_prefix != x ; then
       aalib_args="$aalib_args --prefix=$aalib_prefix"
       if test x${AALIB_CONFIG+set} != xset ; then
          AALIB_CONFIG=$aalib_prefix/bin/aalib-config
       fi
    fi

This is then used to invoke 'aalib-config' with the correct prefix. However,
the use of 'aalib_args' is inconsistent. It is used as 'aalibconf_args' and
'aalib_config_args' rather than 'aalib_args'

    AALIB_CFLAGS=`$AALIB_CONFIG $aalibconf_args --cflags`
    AALIB_LIBS=`$AALIB_CONFIG $aalibconf_args --libs`

    aalib_major_version=`$AALIB_CONFIG $aalib_args --version | \
           sed 's/\([0-9]*\).\([0-9]*\).\([0-9]*\)/\1/'`
    aalib_minor_version=`$AALIB_CONFIG $aalib_args --version | \
           sed 's/\([0-9]*\).\([0-9]*\).\([0-9]*\)/\2/'`
    aalib_micro_version=`$AALIB_CONFIG $aalib_config_args --version | \
           sed 's/\([0-9]*\).\([0-9]*\).\([0-9]*\)/\3/'`

This results in host flags being returned because the '--prefix' is not
forwarded on correctly. The fix is to use 'aalib_args' for all of the
invocations of 'aalib-config' as so:

    AALIB_CFLAGS=`$AALIB_CONFIG $aalib_args --cflags`
    AALIB_LIBS=`$AALIB_CONFIG $aalib_args --libs`

    aalib_major_version=`$AALIB_CONFIG $aalib_args --version | \
           sed 's/\([0-9]*\).\([0-9]*\).\([0-9]*\)/\1/'`
    aalib_minor_version=`$AALIB_CONFIG $aalib_args --version | \
           sed 's/\([0-9]*\).\([0-9]*\).\([0-9]*\)/\2/'`
    aalib_micro_version=`$AALIB_CONFIG $aalib_args --version | \
           sed 's/\([0-9]*\).\([0-9]*\).\([0-9]*\)/\3/'`

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.