[Bug 759533] vaapisink: doesn't upload packed formats correctly

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=759533

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #348777|none                        |needs-work
             status|                            |

--- Comment #25 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 348777:
 --> (https://bugzilla.gnome.org/review?bug=759533&attachment=348777)

::: gst-libs/gst/vaapi/gstvaapiwindow_wayland.c
@@ +331,3 @@

+  gst_vaapi_filter_replace (&window->filter, NULL);
+  gst_vaapi_video_pool_replace (&window->surface_pool, NULL);

Somehow I feel we should move this into gstvaapiwindow, since these variables
are private to GstVaapiWindow

@@ +347,3 @@
   GST_DEBUG ("resize window, new size %ux%u", width, height);

+  gst_vaapi_video_pool_replace (&window->surface_pool, NULL);

ditto

::: gst-libs/gst/vaapi/gstvaapiwindow_x11.c
@@ +300,3 @@
+
+  gst_vaapi_video_pool_replace (&window->surface_pool, NULL);
+  gst_vaapi_filter_replace (&window->filter, NULL);

move to GstVaapiWindow class

@@ +463,3 @@
+          gst_vaapi_window_x11_put_surface (window, surface_id, src_rect,
+          dst_rect, flags);
+      gst_vaapi_video_pool_put_object (window->surface_pool, vpp_surface);

This mean that right after vaPutSurface() the vpp_surface can be removed at
anytime. Are we sure that vaPutSurface works synchronously?

@@ +465,3 @@
+      gst_vaapi_video_pool_put_object (window->surface_pool, vpp_surface);
+
+      if (!(ret = vaapi_check_status (status, "vaPutSurface()"))) {

this if () is really needed. AFAIK we only need to get the ret =
vaapi_check_status() because the next sentence is return, either true o false.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.