[Bug 759533] vaapisink: doesn't upload packed formats correctly

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=759533

--- Comment #27 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #25)
> Review of attachment 348777 [details] [review]:
> 
> ::: gst-libs/gst/vaapi/gstvaapiwindow_wayland.c
> @@ +331,3 @@
>  
> +  gst_vaapi_filter_replace (&window->filter, NULL);
> +  gst_vaapi_video_pool_replace (&window->surface_pool, NULL);
> 
> Somehow I feel we should move this into gstvaapiwindow, since these
> variables are private to GstVaapiWindow
>

Good point.
I was trying to destroy them in GstVaapiWindow, but currently, X11/Wayland
VaapiWindow are not decendant of it. 
So we should choose:
1. Make them children of GstVaapiWindow.
2. Just implements new internal function to destroy stuff in GstVaapiWindow.

Probably, we should do option 1, opinion?


> @@ +463,3 @@
> +          gst_vaapi_window_x11_put_surface (window, surface_id, src_rect,
> +          dst_rect, flags);
> +      gst_vaapi_video_pool_put_object (window->surface_pool, vpp_surface);
> 
> This mean that right after vaPutSurface() the vpp_surface can be removed at
> anytime. Are we sure that vaPutSurface works synchronously?

Another good point:)
Actually I had doubt of this, but not found something unexpected.
But I think I can call surface sync api after put surface.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.