[Bug 779787] waylandsink: handling y-flipped dmabuf

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Mar 31 03:57:37 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=779787

--- Comment #5 from Damian Hobson-Garcia <dhobsong at igel.co.jp> ---
Apologies for the late response.

(In reply to Nicolas Dufresne (stormer) from comment #4)
> (In reply to Damian Hobson-Garcia from comment #3)

> This is not our problem if there was a bug in a unstable protocol
> implementation at some random point in time. If you want to hack support for
> that in your product, it's your call. It does not make sense upstream.

I see your point.

> 
> The right approach here entirely depend on the following factor:
> 1. Is the memory controller fixing it on mmap ?
> 2. Is the DMABuf mappable ?
> 

After poking around some more through the GL plugin code, it looks like dmabuf
is only used when uploading to GL textures, and that buffers are mmapp'ed
(which "fixes" the orientation) and presented as shm buffer to the wayland
compositor.  Given that, combined with the fact any hacks to address the 
"polarity" issue don't belong upstream, I can't really think of any case where
the ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT flag needs to be set. So maybe
this patch (or any variation of it) isn't really needed after all. Sorry for
wasting your time.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list