[Bug 780331] interleave segfaults with more than 64 channels

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780331

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #348562|accepted-commit_now         |committed
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Comment on attachment 348562
  --> https://bugzilla.gnome.org/attachment.cgi?id=348562
patch series

commit a9f26c2a14928cf666bbbea0d0320a7681bdabb3
Author: Douglas Bagnall <douglas at halo.gen.nz>
Date:   Fri Mar 24 00:11:13 2017 +1300

    interleave: avoid using uninitialised ordering_map

    If self->channel_positions == NULL (which seems unlikely),
    self->default_channels_ordering_map will be used unintialised.

    We avoid that by keeping track of the channel_mask, which is set when
    the ordering map is initialised.

    https://bugzilla.gnome.org/show_bug.cgi?id=780331

commit c08d719453e1b6347531fa0d050cb02043d2d6f4
Author: Douglas Bagnall <douglas at halo.gen.nz>
Date:   Thu Mar 23 23:56:31 2017 +1300

    interleave: don't overflow channel map with >64 channels

    When there are more than 64 channels, we don't want to exceed the
    bounds of the ordering_map buffer, and in these cases we don't want to
    rempa at all. Here we avoid doing that.

    https://bugzilla.gnome.org/show_bug.cgi?id=780331

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.