[Bug 780767] New: videorate: buffers are copied in drop-only mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780767

            Bug ID: 780767
           Summary: videorate: buffers are copied in drop-only mode
    Classification: Platform
           Product: GStreamer
           Version: unspecified
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: gdesmott at gnome.org
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

The 'drop-only' mode is supposed to not perform any copy (needed in zero-copy
pipelines). Bug #764319 meant to avoid copying in this mode but I still get
copies with this simple pipeline: "videotestsrc ! videorate drop-only=true !
fakesink".

- gst_video_rate_transform_ip() is called with a buffer (refcount == 1)
- it calls gst_video_rate_swap_prev(), setting videorate->prevbuf to the
current buffer and so increasing its refcount to 2
- gst_video_rate_flush_prev() is called, videorate->prevbuf is reffed and then
videorate->prevbuf is unset, so the refcount is still 2
- gst_buffer_make_writable() copies the buffer as the refcount is > 1

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.