[Bug 775615] decodebin3: Select default track by GstStreamFlags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775615

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #350372|none                        |needs-work
             status|                            |

--- Comment #24 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 350372:
 --> (https://bugzilla.gnome.org/review?bug=775615&attachment=350372)

::: gst/playback/gstdecodebin3.c
@@ +1127,3 @@
+
+  if (ret != 0) {
+    GST_LOG ("Sort by stream-type: %d", ret);

You can just put this block in the previous block ("if (typea != typeb)").

@@ +1147,3 @@
+  ida = gst_stream_get_stream_id (sa);
+  idb = gst_stream_get_stream_id (sb);
+  ret = (ida) ? ((idb) ? (g_strcmp0 (ida, idb) > 0 ? 1 : -1) : -1) : 1;

No need to check if ida/idb are NULL or not. g_strcmp0 handles NULL inputs.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.